Skip to content

Fix delay when navigating to a cluster#17641

Closed
richard-cox wants to merge 6 commits into
rancher:masterfrom
richard-cox:fix-load-cluster-delay
Closed

Fix delay when navigating to a cluster#17641
richard-cox wants to merge 6 commits into
rancher:masterfrom
richard-cox:fix-load-cluster-delay

Conversation

@richard-cox
Copy link
Copy Markdown
Member

@richard-cox richard-cox commented May 13, 2026 •
edited
Loading

Summary

Occurred changes and/or fixed issues

  • loadCluster --> await dispatch('cluster/unsubscribe'); --> cleanupTasks.push(waitFor(() => !this.$workers[getters.storeName], 'Worker is destroyed'));
  • the waitFor was not immediately resolved, so waited the default 500ms before checking again
  • for some reason we're now not in the immediate world so wait the 500ms
  • resolution is to reduce the delay in waitFor to 50ms

Technical notes summary

  • i haven't managed to work out why this is now an issue, so this is almost a work around (but a logical one)

Areas or cases that should be tested

  • home page --> cluster list --> cluster (quicker than before, at least 450ms)

Areas which could experience regressions

  • cluster --> home page --> cluster list (this is as quick as before)

Checklist

  • The PR is linked to an issue and the linked issue has a Milestone, or no issue is needed
  • The PR has a Milestone
  • The PR template has been filled out
  • The PR has been self reviewed
  • The PR has a reviewer assigned
  • The PR has automated tests or clear instructions for manual tests and the linked issue has appropriate QA labels, or tests are not needed
  • The PR has reviewed with UX and tested in light and dark mode, or there are no UX changes
  • The PR has been reviewed in terms of Accessibility
  • The PR has considered, and if applicable tested with, the three Global Roles Admin, Standard User and User Base

@richard-cox richard-cox added this to the v2.15.0 milestone May 13, 2026
@richard-cox richard-cox requested a review from nwmac May 13, 2026 15:08
@richard-cox richard-cox self-assigned this May 13, 2026
nwmac
nwmac previously approved these changes May 13, 2026
View reviewed changes
@richard-cox
Fix delay when navigating to a cluster
f4abfb9 
- `loadCluster` --> `await dispatch('cluster/unsubscribe');` --> cleanupTasks.push(waitFor(() => !this.$workers[getters.storeName], 'Worker is destroyed'));
- the waitFor was not immediately resolved, so waited the default 500ms before checking again
- for some reason we're now not in the immediate world so wait the 500ms
- resolution is to reduce the delay in waitFor to 50ms
@richard-cox richard-cox force-pushed the fix-load-cluster-delay branch from 3b2fa94 to f4abfb9 Compare May 14, 2026 10:26
@richard-cox richard-cox force-pushed the fix-load-cluster-delay branch from bd2042a to 04e719e Compare May 15, 2026 13:16
@richard-cox richard-cox force-pushed the fix-load-cluster-delay branch from c74b94b to f77123a Compare May 15, 2026 15:27
@richard-cox richard-cox mentioned this pull request May 18, 2026
Closed
9 tasks
@richard-cox
Copy link
Copy Markdown
Member Author

richard-cox commented May 18, 2026 •
edited
Loading

Given CI strangeness will experiment in a separate PR - #17703

  1. no code change
    • result - passed after initial run + automatic re-run (explorer + generic suites)
  2. no code change - 2
    • result - passed after initial run + automatic re-run + 2 x manual re-run (manager)
  3. args parsed in, no change from default
    • result - passed after initial run + automatic re-run (explorer + manager suites)
  4. args parsed in, minor change (500 interval --> 499)
    • result - passed after initial run + automatic re-run + 1 x manual re-run (no-vai + manager)
  5. args parsed in, as previous PR
    • result - failed after initial run + automatic re-run (navigation, explorer2, components)
  6. args parsed in, added waitFor debug
    • result - failed after initial run + automatic re-run (navigation, explorer, explorer2, components)

@richard-cox richard-cox mentioned this pull request May 19, 2026
Merged
9 tasks
@richard-cox
Copy link
Copy Markdown
Member Author

richard-cox commented May 19, 2026

Closed in favour of #17733

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@nwmac nwmac nwmac left review comments

Assignees

@richard-cox richard-cox

Labels

None yet

Projects

None yet

Milestone

v2.15.0

Development

Successfully merging this pull request may close these issues.

2 participants

@richard-cox @nwmac